Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-integraiton: Refresh the file system variants list #69

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

anoopcs9
Copy link
Collaborator

Optimizations included:

  • cephfs.vfs configuration is grouped inside cephfs.
  • cephfs.mgr.vfs can be just cephfs.mgr.

depends on samba-in-kubernetes/sit-environment#117

With [1] all possible share configurations are grouped after their
respective backend file system. So those duplicate entries can be
removed reducing the number of jobs in the matrix.

[1] samba-in-kubernetes/sit-environment#117
With [1] suffix 'vfs' is irrelevant in 'cephfs.mgr.vfs' as multiple
share configurations are included within mgr variant.

[1] samba-in-kubernetes/sit-environment#117
Copy link

dpulls bot commented Aug 28, 2024

🎉 All dependencies have been resolved !

@anoopcs9 anoopcs9 changed the title fs-integraiton: Refresh the file sytem varaints list fs-integraiton: Refresh the file system variants list Aug 28, 2024
@anoopcs9 anoopcs9 requested a review from xhernandez August 28, 2024 09:04
@xhernandez
Copy link
Contributor

@anoopcs9 @spuiuk When multiple share configurations are created for a single backend, does sit-test-cases currently run all tests on all shares ?

@anoopcs9
Copy link
Collaborator Author

@anoopcs9 @spuiuk When multiple share configurations are created for a single backend, does sit-test-cases currently run all tests on all shares ?

Yes.

@xhernandez
Copy link
Contributor

@anoopcs9 @spuiuk When multiple share configurations are created for a single backend, does sit-test-cases currently run all tests on all shares ?

Yes.

Great. Thanks !

@anoopcs9 anoopcs9 merged commit ef20a6e into samba-in-kubernetes:main Aug 28, 2024
2 checks passed
@anoopcs9 anoopcs9 deleted the rm-invalid-fs-entries branch August 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants